Improve GobView build #1215
Merged
Improve GobView build #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sim642
reviewed
Oct 12, 2023
sim642
reviewed
Nov 2, 2023
stilscher
force-pushed
the
improve-gobview-build
branch
from
2739567 to
660a678
Compare
stilscher
force-pushed
the
improve-gobview-build
branch
from
a883207 to
1e7c6fe
Compare
|
What is blocking the merge here? |
|
I think we do want to have a separate distribution directory for GobView, but that requires some additional changes to the goblint-http server that need to be realized in the GobView repository first. |
sim642
reviewed
Feb 15, 2024
There was a problem hiding this comment.
Sorry for forgetting about this again!
I guess this should all work once conflicts with master are resolved and the submodule is updated to goblint/gobview#33.
sim642
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to simplify the build process and usage of GobView:
new make target that copies the executable to the top-level directory (as done with the Goblint executable)
copy the transpiled JavaScript files during the build already instead of doing it during the first run of Goblint (this allows to later extend GobView to start the first run from within the UI)
update documentation
bump Gobview after Serve files from separate distribution directory gobview#33 has been merged