Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be more precise for << of Intervals #1252

Merged
merged 5 commits into from
Nov 21, 2023
Merged

Be more precise for << of Intervals #1252

merged 5 commits into from
Nov 21, 2023

Conversation

michael-schwarz
Copy link
Member

Closes #1250

@michael-schwarz michael-schwarz added sv-comp SV-COMP (analyses, results), witnesses precision labels Nov 17, 2023
@michael-schwarz michael-schwarz added this to the SV-COMP 2024 milestone Nov 17, 2023
@michael-schwarz
Copy link
Member Author

This also means we succeed on the relevant SV-COMP task.

@michael-schwarz
Copy link
Member Author

Looks .like there's a few more SV-COMP No-Overflow tasks where this helps :)

@michael-schwarz
Copy link
Member Author

Fails on some LDV tasks e.g.

./goblint --conf conf/svcomp24.json --sets ana.specification /home/goblint2/svcomp/sv-benchmarks/c/properties/unreach-call.prp --sets exp.architecture 64bit /home/goblint2/svcomp/sv-benchmarks/c/ldv-linux-3.0/usb_urb-drivers-video-arkfb.ko.cil.out.i

with

Fatal error: exception Invalid_argument("Z.shift_left: count argument must be positive")

@michael-schwarz michael-schwarz marked this pull request as draft November 19, 2023 17:11
@michael-schwarz michael-schwarz self-assigned this Nov 19, 2023
@michael-schwarz michael-schwarz marked this pull request as ready for review November 19, 2023 18:28
sim642
sim642 reviewed Nov 20, 2023
View reviewed changes
src/cdomains/intDomain.ml Outdated Show resolved Hide resolved
@michael-schwarz
Copy link
Member Author

Since this has an overall positive effect, I suggest to merge.

@jerhard jerhard merged commit 26deafb into master Nov 21, 2023
16 checks passed
@jerhard jerhard deleted the issue_1250 branch November 21, 2023 11:28
sim642 added a commit that referenced this pull request Nov 21, 2023
@sim642
Adapt cram test from #1258 to #1252
9c808c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sim642 sim642 sim642 approved these changes

@jerhard jerhard jerhard approved these changes

Assignees

@michael-schwarz michael-schwarz

Labels
precision sv-comp SV-COMP (analyses, results), witnesses
Projects
None yet
Milestone
SV-COMP 2024
Development

Successfully merging this pull request may close these issues.

Be more precise for overflow warnings for shifts
3 participants
@michael-schwarz @sim642 @jerhard