Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize constraint system and value domain modules into dune libraries #1313

Merged
merged 12 commits into from
Dec 29, 2023

Conversation

sim642
Copy link
Member

@sim642 sim642 commented Dec 28, 2023

This continues #1288.

Previously Analyses was a mix of constraint systems, analysis specifications and analysis result outputting. By splitting this module up, constraint systems and solvers can nicely be isolated.

The other big chunk at the bottom of goblint.lib dependency graph was all the various ValueDomain parts. All analyses indirectly depend on them due to the existence of the EvalValue query.
A couple of not-so-related modules also come along for now. We'll have to find a better place for those later.

This PR introduces new dune libraries:

  1. goblint.constraint for (side-effecting) constraint systems.
  2. goblint.solver for solvers.
  3. goblint.cdomain.value for ValueDomain and all of its components.

TODO

@sim642 sim642 added the cleanup Refactoring, clean-up label Dec 28, 2023
@sim642 sim642 added this to the v2.4.0 milestone Dec 28, 2023
@sim642 sim642 changed the title Organize more common modules into dune libraries Organize constraint system and value domain modules into dune libraries Dec 28, 2023
@michael-schwarz michael-schwarz self-requested a review December 28, 2023 16:35
@sim642 sim642 merged commit 9d1dc02 into master Dec 29, 2023
17 checks passed
@sim642 sim642 deleted the goblint-dune-libs-3 branch December 29, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Refactoring, clean-up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants