Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

affeq: Fix array OOB in invariant #1327

Merged
merged 4 commits into from
Jan 13, 2024
Merged

affeq: Fix array OOB in invariant #1327

merged 4 commits into from
Jan 13, 2024

Conversation

michael-schwarz
Copy link
Member

During benchmarking for #1297, it became apparent that the invariant function in affeq accesses arrays out-of-bounds due to an off-by-one error.

This fixes the issue and adds a test that has witness generation enabled to spot regressions.

Copy link
Member

@sim642 sim642 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems right, although the entire invariant is very roundabout: MatrixearrayarrayEnumlist. A single List.init should do it.

Co-authored-by: Julian Erhard <[email protected]>
@michael-schwarz michael-schwarz merged commit c0c8960 into master Jan 13, 2024
17 checks passed
@michael-schwarz michael-schwarz deleted the affeq_witnesses branch January 13, 2024 15:40
@michael-schwarz michael-schwarz added this to the v2.4.0 milestone Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants