Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanity test all solvers and fix topdown_term & slr3 #1605

Merged
merged 7 commits into from
Dec 16, 2024
Merged

Conversation

sim642
Copy link
Member

@sim642 sim642 commented Oct 25, 2024

We've kept various solvers around and compiling, but they're untested. For example, it turns out that topdown_term is completely broken and only computes bottoms.

Changes

  1. Adds cram test for 00-sanity/01-assert to check minimal functioning of all solvers.
  2. Fix start variables in topdown_term to restore basic functionality.
  3. Fix invalid widen call in topdown_term for side effects.
  4. Fix invalid widen call in slr3 for globals.
  5. Fix option name in topdown_space_cache_term.
  6. Disable broken two solver.

src/solver/sLR.ml Outdated Show resolved Hide resolved
src/solver/sLR.ml Outdated Show resolved Hide resolved
@sim642 sim642 changed the title Sanity test all solvers and fix topdown_term Sanity test all solvers and fix topdown_term & slr3 Dec 16, 2024
@sim642 sim642 added this to the v2.6.0 milestone Dec 16, 2024
@sim642 sim642 merged commit b68df11 into master Dec 16, 2024
21 checks passed
@sim642 sim642 deleted the topdown_term branch December 16, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants