Skip to content

Remove GraphML witness export #1738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Remove GraphML witness export #1738

wants to merge 13 commits into from
+650 −1,242

Conversation

sim642
Copy link
Member

@sim642 sim642 commented May 2, 2025

Closes #1732.

@sim642 sim642 added cleanup Refactoring, clean-up sv-comp SV-COMP (analyses, results), witnesses labels May 2, 2025
@sim642 sim642 added this to the SV-COMP 2026 milestone May 2, 2025
@michael-schwarz
Copy link
Member

michael-schwarz commented May 2, 2025 •
edited
Loading 

|> lift arg_enabled (module WitnessConstraints.PathSensitive3)

Should this module be renamed? Its connection to witnesses is only historical at this point.
Maybe one can make an ARG folder? Then things such as ArgTools and MyARG are also removed from the witness folder.

@michael-schwarz michael-schwarz self-requested a review May 2, 2025 10:38
michael-schwarz
michael-schwarz approved these changes May 2, 2025
View reviewed changes
Copy link
Member

@michael-schwarz michael-schwarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my comments above, this looks good to go!

@sim642
Copy link
Member Author

sim642 commented May 2, 2025 

|> lift arg_enabled (module WitnessConstraints.PathSensitive3)

Should this module be renamed? It's connection to witnesses is only historical at this point. Maybe one can make an ARG folder? Then things such as ArgTools and MyARG are also removed from the witness folder.

I now moved them around and renamed this module.
I also moved ARG things around in the documentation, which I thought about at one point but then forgot, so thanks for the reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-schwarz michael-schwarz michael-schwarz approved these changes

Assignees
No one assigned
Labels
cleanup Refactoring, clean-up sv-comp SV-COMP (analyses, results), witnesses
Projects
None yet
Milestone
SV-COMP 2026
Development

Successfully merging this pull request may close these issues.

Remove support for GraphML witnesses?
2 participants
@sim642 @michael-schwarz