Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subscription request type #162

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix subscription request type #162

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1c9d40
fix subscription request type
KLewin23 Sep 14, 2023
f71dfd4
fix subscription create day_of_month type
KLewin23 Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/types/Types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3984,7 +3984,7 @@ export interface ListMetaCursor {
export interface Subscription {
// Amount in the lowest denomination for the currency (e.g. pence in GBP,
// cents in EUR).
amount?: string;
amount?: number;

// The amount to be deducted from each payment as an app fee, to be paid to
// the partner integration which created the subscription, in the lowest
Expand All @@ -4005,7 +4005,7 @@ export interface Subscription {

// As per RFC 2445. The day of the month to charge customers on. `1`-`28` or
// `-1` to indicate the last day of the month.
day_of_month?: string | null;
day_of_month?: number | null;

// The earliest date that will be used as a `charge_date` on payments
// created for this subscription if it is resumed. Only present for `paused`
Expand Down