Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types only: Expose typings for Got agent in client options #171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Types only: Expose typings for Got agent in client options #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/api/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@ import process = require('process');
import _ = require('lodash');
import { v4 as uuidv4 } from 'uuid';
import * as url from 'url';
import got from 'got';
import got, { Agents } from 'got';
import qs from 'qs';

import { Environments, CLIENT_VERSION, API_VERSION } from '../constants';
import * as GoCardlessErrors from '../errors';

interface APIOptions {
proxy?: object;
export interface APIOptions {
proxy?: Agents;
raiseOnIdempotencyConflict?: boolean;
}

Expand All @@ -36,7 +36,7 @@ export class Api {
private _token: string;
private _environment: Environments;
private _baseUrl: string;
private _agent: object;
private _agent: Agents | undefined;
private raiseOnIdempotencyConflict: boolean;

private processVersion: string;
Expand Down
4 changes: 2 additions & 2 deletions src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';

import { Environments } from './constants';
import { Api } from './api/api';
import { Api, APIOptions } from './api/api';
import { BankAuthorisationService } from './services/bankAuthorisationService';
import { BankDetailsLookupService } from './services/bankDetailsLookupService';
import { BillingRequestService } from './services/billingRequestService';
Expand Down Expand Up @@ -71,7 +71,7 @@ export class GoCardlessClient {
private _verificationDetails: VerificationDetailService;
private _webhooks: WebhookService;

constructor(token: string, environment = Environments.Live, options = {}) {
constructor(token: string, environment = Environments.Live, options: APIOptions = {}) {
this._api = new Api(token, environment, options);

this._bankAuthorisations = undefined;
Expand Down