Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes from gocardless-nodejs-template #202

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Changes from gocardless-nodejs-template #202

merged 3 commits into from
Dec 4, 2024

Conversation

azidouk
Copy link
Contributor

@azidouk azidouk commented Dec 4, 2024

PR should have been created automatically but was not. All required changes are pushed from the template repo

@azidouk azidouk self-assigned this Dec 4, 2024
@@ -1,6 +1,6 @@
{
"name": "gocardless-nodejs",
"version": "4.1.0",
"version": "4.3.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 4.2.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the unfortunate result of the last merge that didn't result in a version bump on this side.
Basically, in my last merge to the template repo, the version was bumped to 4.2. However, no changes were pushed here.
When I created a new PR in the template repo, I was worried about keeping the version number as it was (4.2) and submitting other changes because I was worried we would internally have checks for version numbers and only trigger the push if they were different.

Our options are either to keep it as is, or go back to the template repo, lower the version to 4.2 then do the merge again (and I am not sure if that is allowed in the template repo).

My preferred approach would be to keep this as is to avoid any more confusion, but please let me know if you have any objections

src/constants.ts Show resolved Hide resolved
@azidouk azidouk merged commit 8fa0f66 into master Dec 4, 2024
3 checks passed
@azidouk azidouk deleted the template-changes branch December 4, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants