Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix property read syntax to supported by more tools #188

Closed

Conversation

VincentLanglet
Copy link

Hi,

This PR is kinda similar to #186 in the idea

The issue I encountered is that the syntax

@property-read $foo

is not a valid one for lot of PHPtool, and

@property-read TYPE $foo

should be preferred instead.

Since none of the property are typed in this lib,

@property-read mixed $foo

does the job.

As an example,

In the same way, all this files are generated by crank, so I cannot contribute to them.
Is there a way to have acces to crank or that someone move this fix to the crank library @barrucadu @Nimisoere @opsz2 @NickLewry ?

Thanks

@VincentLanglet VincentLanglet force-pushed the fixPropertyReadPhpdoc branch from 378fbeb to ab2d615 Compare August 9, 2024 22:07
@VincentLanglet
Copy link
Author

Hi @KarmanLeung, since you recently merged a PR on this lib, maybe could you help me about this one ?

Thanks

@KarmanLeung KarmanLeung mentioned this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant