forked from sorintlab/stolon
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert gocardless/stolon to Github Actions #66
Open
sam-robson
wants to merge
16
commits into
gocardless-v0.17.0+
Choose a base branch
from
convert-gocardless-stolon-to-actions-20221012-105611
base: gocardless-v0.17.0+
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Convert gocardless/stolon to Github Actions #66
sam-robson
wants to merge
16
commits into
gocardless-v0.17.0+
from
convert-gocardless-stolon-to-actions-20221012-105611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-robson
commented
Oct 12, 2022
sam-robson
force-pushed
the
convert-gocardless-stolon-to-actions-20221012-105611
branch
2 times, most recently
from
October 27, 2022 17:32
e58fae8
to
a8ae66b
Compare
sam-robson
force-pushed
the
convert-gocardless-stolon-to-actions-20221012-105611
branch
from
October 27, 2022 17:33
a8ae66b
to
26eca3b
Compare
And to also mimic the release we had for pubsubtle, rather than the two step release we had in circleci
DragosDumitrache
force-pushed
the
convert-gocardless-stolon-to-actions-20221012-105611
branch
from
November 14, 2022 13:52
9eeb86a
to
5e7cf55
Compare
Comment on lines
2
to
8
on: | ||
push: | ||
branches: | ||
- gocardless-v0.17.0+ | ||
pull_request: | ||
branches: | ||
- gocardless-v0.17.0+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, with the following filters in place, CI doesn't even run on PRs
This ensures we don't go looking at the upstream for this sort of work
pull_request_target didn't seem to register as a trigger, which leads me to believe this isn't the right trigger for forks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipeline migrated from Circle CI 🎉