Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if no remote validator was specified #602

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

koplas
Copy link
Contributor

@koplas koplas commented Dec 4, 2024

Prints a warning if no remote validator was configured.

Closes #601

s-l-teichmann
s-l-teichmann previously approved these changes Dec 4, 2024
Copy link
Contributor

@s-l-teichmann s-l-teichmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @koplas I have reworked the exit code doc part to make it more clear that the bits are superposed .. Its a bit technical .. so if you have a better wording?

@koplas
Copy link
Contributor Author

koplas commented Dec 4, 2024

LGTM @koplas I have reworked the exit code doc part to make it more clear that the bits are superposed .. Its a bit technical .. so if you have a better wording?

Most documentations have a table with a Hex Mask, but this is even more technical. This approach seems good enough for me.

@koplas koplas requested a review from JanHoefelmeyer December 6, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

csaf_validator: Warn if remote_validator is not configured
2 participants