Initial upload of decbinhex demo #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original demo for 3.X was contributed to @zetashift's demo repo. Issue note: The line if isRunningInEditor: return worked when I used 1 add-on, but as soon as I broke polygon_class.nim off into its own thing that line no longer works.
panno8M
reviewed
Jul 30, 2024
Previous version still exists a hidden object
panno8M
reviewed
Jul 30, 2024
|
I didn't upload the changes yet, I was still trying to see if I could improve my logo for 16x16 view |
|
I'm sorry. I would like you to set up a new PR. |
Done. The pull was at least in a usable state (will still compile) but yeah I should've converted it to a draft when you requested changes. Also not sure if you saw it in my other comment, but the error with the isRunning thing is caused by the ExtensionManager being registered more than once. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original demo for 3.X was contributed to @zetashift's demo repo.
Issue note: The line
if isRunningInEditor: returnworked when I used 1 add-on, but as soon as I broke polygon_class.nim off into its own thing that line no longer works (but the rest of it does, this is somewhat an issue especially because classes run even when the class is hidden, meaning a user could accidentally move the polygon permanently).