-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Popup content_scale_factor
#104399
Improve Popup content_scale_factor
#104399
Conversation
8d6ee8d
to
2e3e97c
Compare
2e3e97c
to
1ee6f6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, it works as expected both with subwindow embedding enabled and disabled.
However, when subwindow embedding is disabled, the stretched popup will be blurry when using the viewport
stretch mode (instead of being pixelated as I'd expect). I recall seeing another issue (and PR) specifically tackling this.
Subwindow embedding enabled
disabled |
canvas_items |
viewport |
---|---|---|
![]() |
![]() |
![]() |
Subwindow embedding disabled
disabled |
canvas_items |
viewport |
---|---|---|
![]() |
![]() |
![]() |
Also, this PR doesn't fix #98672:
|
1ee6f6e
to
1a8828a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be working as expected with both embedded and native windows.
content_scale_factor
This makes sense to do, but I can see use cases where this is an issue. In general, we discourage using Control scaling outside of animation purposes (as it breaks within containers), but if you do use it for animation, it might look weird if it affects the tooltip at the same time as the button. |
So, should I cancel it? |
1a8828a
to
5ed281e
Compare
Yes, I suggest removing that change from the PR then submitting it in a separate PR instead. |
5ed281e
to
27438a1
Compare
Done. |
Change the content_scale_factor used by some Popups from being retrieved from the parent Window to being retrieved from the parent Viewport.
Fix #69749
Fix #69171
Fix #98672
master:


this pr:


test:

popup_test_2025-03-20_23-17-23.zip