Mask out shadows on CanvasItems that don't have a matching item_shadow_mask
#98835
+200
−175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
force-pushed
the
Light2D-shadow-mask
branch
from
57290da
to
d7c1ac4
Compare
akien-mga
changed the title
item_shadow_mask
|
2D shadow masking is working!
notify #93881 |
|
Gonna need to be rebased before this can be merged |
…w_mask This restores the behavior from 3.x
clayjohn
force-pushed
the
Light2D-shadow-mask
branch
from
d7c1ac4
to
2b68c63
Compare
|
Rebased, should be good now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #64939
Fixing this required a small amount of refactoring to move some of the per-instance flags into a new per-batch flag. This was needed to free up the required 16 bits for the shadow mask. We do the actual masking on the CPU and then just store a binary value for whether that lights shadow impacts that CanvasItem. This saves instructions in the shader.