-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve GDScript autocompletion for methods #99102
base: master
Are you sure you want to change the base?
Improve GDScript autocompletion for methods #99102
Conversation
50cbe28
to
17d69b0
Compare
Kinda off-topic, but it surprised me that the back braces will not get overlapped. In previous versions, trying completing your code inside a couple of round brackets will remove the back brace if the completion is about a method or a keyword with print(is_inside_tree() # <- Here the back brace of `is_inside_tree()` is missing, or overlapping with the outer one. I'm not sure if it is this pr or some other pr in this version that fixed this bug, or maybe it's because I haven't tested edge situation yet. But it seems to be a good sign. |
It depends on whether you accept the suggestion with Tab or Enter. See #90723 which changes this behavior to be more predictable. |
0332f3c
to
93387f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering the autocomplete popup uses a monospaced font, and the three dots inside function parentheses take up a considerable width, may I suggest using this character instead?
|
This is indeed a nice improvement. I think the usage of Looks good to me on code and functionality side. You still need to squash the commits before this can get merged. |
7c6dd8e
to
9c9a746
Compare
Ok, now it's squashed, but could we get a meaningful commit name? E.g. just the title of the PR. If you already squashed you can use amend for it: git commit --amend -m "Improve GDScript autocompletion for methods"
git push -f |
9c9a746
to
425976d
Compare
425976d
to
ae853e1
Compare
Implements the part 1 of godotengine/godot-proposals#11079
Check the link for details about the reason why this pr is posted.