-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: support multi wallet connector #201
Draft
RetricSu
wants to merge
4
commits into
develop
Choose a base branch
from
support-multi-wallet
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RetricSu
force-pushed
the
support-multi-wallet
branch
from
October 8, 2022 14:43
499631b
to
dd74f62
Compare
RetricSu
force-pushed
the
support-multi-wallet
branch
from
October 9, 2022 07:47
2feb7b6
to
2613123
Compare
RetricSu
changed the title
wip: support multi wallet connector
feat: support multi wallet connector
Oct 9, 2022
RetricSu
changed the title
feat: support multi wallet connector
Feat: support multi wallet connector
Oct 9, 2022
TestingI've tested for a round or two, here's the connection test results for the newly added wallets.
imTokenNo issues found WalletConnect (MetaMask&imToken):
Safepal
|
thx, I will check the code and see how to resolve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr supports multiple wallet connectors via using
web3-react
lib. For injected webview environment (eg: Metamask/ImToken/SafePal), the connector use Metamask connector, we only add different icons to better identify the wallet, same as Yokai Swap.some todos before merging this pr: