Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @var instead of @property in class-property doc-blocks #98

Merged
merged 3 commits into from
Sep 19, 2019
Merged

Use @var instead of @property in class-property doc-blocks #98

merged 3 commits into from
Sep 19, 2019

Conversation

mkrauser
Copy link
Contributor

see #97

@mkrauser
Copy link
Contributor Author

mkrauser commented Sep 18, 2019

I just saw that the VarTag-Class was added in Zend Code 3.3.2, which requires php 7.1.
This seems like a big bump of the requirements. But it's your decision

@goetas
Copy link
Member

goetas commented Sep 19, 2019

Here is a difficult decision, this project is used mainly on soap/xml related projects ... that deal often with legacy stuff... this still stuck to php 5.x...

Maybe this is a good push for them to update!

@goetas goetas added the bug label Sep 19, 2019
@mkrauser
Copy link
Contributor Author

@goetas Since only >= php 7.1 is officially supported, I would bump the requirements.
I bet the users who are still using php 5.x are already having problems anyway. And if they want/need to, they can still use older versions.

@goetas goetas merged commit 5258cf8 into goetas-webservices:master Sep 19, 2019
@goetas
Copy link
Member

goetas commented Sep 19, 2019

Alright!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants