-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FSR_QC.csv #460
base: main
Are you sure you want to change the base?
Update FSR_QC.csv #460
Conversation
Update FSR_QC.CSV - issue 454 EuBIC-MS
Here are the changes in FSR_QC.csv:
|
Hi @anjuraj15 - I've modified the PR comment to link the issue. |
FSR_QC.csv
Outdated
@@ -1,4 +1,4 @@ | |||
1. issue number,1. Person name,1. ORCID,1. FSR long name,1. FSR thing,1. FSR np identifier,1. URI of duplicate(s) (multiple separated by ';'),1. Links correct,1. Proposed Links,1. Definition ok,1. FSR types ok,1. FAIRSharing DOI to be added,1. FSR creator in pubinfo (yellow): FIP Wizard (F) or the ORCID,1. proposal: accept (A) / Improve (I) / Retract (R) / Disapprove (D),1. Proposed changes:,2. actual changes: accept (A) / Improve (I) / Retract (R) / Disapprove (D),2. URI of updated FSR,"2. if FSR is useless, check affected FIPs or SIPs (title)",2. Updated (U) /Deleted (D) entry in FIP/SIP | |||
,1. Person name,1. ORCID,1. FSR long name,1. FSR thing,1. FSR np identifier,1. URI of duplicate(s) (multiple separated by ';'),1. Links correct,1. Proposed Links,1. Definition ok,1. FSR types ok,1. FAIRSharing DOI to be added,1. FSR creator in pubinfo (yellow): FIP Wizard (F) or the ORCID,1. proposal: accept (A) / Improve (I) / Retract (R) / Disapprove (D),1. Proposed changes:,2. actual changes: accept (A) / Improve (I) / Retract (R) / Disapprove (D),2. URI of updated FSR,"2. if FSR is useless, check affected FIPs or SIPs (title)",2. Updated (U) /Deleted (D) entry in FIP/SIP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The header row of the CSV has accidentally been changed. The first column header "1. issue number" will need to be reinstated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree
FSR_QC.csv
Outdated
@@ -17,3 +17,4 @@ | |||
352,Barbara Magagna,0000-0003-2195-3997,Darwin Core,http://purl.org/np/RAaSo_0hEIHE2SUOsdN-Y27AfIp9Kf-YI-lrvDYORo9JA#DwC,http://purl.org/np/RAaSo_0hEIHE2SUOsdN-Y27AfIp9Kf-YI-lrvDYORo9JA,"http://purl.org/np/RAdf9taM_Gyq2-WavUq3CxaVIvsHockMXzonj3W_igNhM,http://purl.org/np/RABFB5JSqq0yM8qBWjlsvMJD-w3sCnOQlw7Sdb0Oc-xmU,http://purl.org/np/RAFmqYVBtOTURhXkRP0EHLqMV5HBXa5nrvHJS9SxTmwhg",,,,,,0000-0001-8050-0299,D,,D,,N/A, | |||
147,Barbara Magagna,0000-0003-2195-3997,DEIMS-SDR_Site_Metadata_Model,http://purl.org/np/RAS95nqgBVT5tVaQiUfCwgFWjxIiwxtkZlkeMIRLDw9KU#DEIMS-SDR_SMM,http://purl.org/np/RAktO6jJg-krEZKPkHe2rZrymGybzgM-EaS2mm1TTTh10,,N,,N,Y,,F,I,"Improve label, definition with more details",I,http://purl.org/np/RAScP6OoU6ybnuVBXFumbMCg8eOGy4I6p_LUQaFo8jTPM,, | |||
423,Barbara Magagna,0000-0003-2195-3997,DataOne,http://purl.org/np/RAU2z2ehbJpnRHujQ5WnovRc2RrSI9nn6qbJ-P4OQt_sQ#DataONE,http://purl.org/np/RAo5M3uFEF2OeBUvfcXESfGBKng9zAu8M6OsKZBeSVyRY,,N,,Y,Y,,F,I,"Improve label to DataONE data management platform, change access URL to https://search.dataone.org/data",I,http://purl.org/np/RAKk8fx2D_JUEYhovoh5Jqz4-YAAq-qh81Ig14vtWFylk,, | |||
454,Anjana Elapavalore,0000-0002-0295-6618,EuBIC-MS | EuBIC-MS (European Bioinformatics Community for Mass Spectrometry),http://purl.org/np/RAM97cdpYSchgAbbj_lF70I7ecn7LeSycJ_glSqjR7Fxw#EuBIC-MS,http://purl.org/np/RAM97cdpYSchgAbbj_lF70I7ecn7LeSycJ_glSqjR7Fxw,,Y,,Y,Y,,F,A,Accept,,,, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In terms of the links being correct, I'm not convinced as I get a 404 for https://w3id.org/gff/fip/terms/Mature-community and a 504 for https://aims.fao.org/aos/agrovoc/c_4318 - this might need escalation via @mabablue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Definition ok" should be 0 (FIC supercommunity incorrect)
"FSR creator in pubinfo (yellow): FIP Wizard (F) or the ORCID" should be Parul's ORCID
proposal should be "I" (improve)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi Robin, this link: https://w3id.org/gff/fip/terms/Mature-community is not yet active but will be this week
so please accept it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rbramley the agrovoc is a famous terminology but actually it is not resolving properly ... I would not worry too much at this stage, and accept it... we are using the srao ontology from FAIRSharing that imported that concept
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@burgerga I completely agree with you. Parul has put in a supercommunity by adding a string.. "promeotics" instead of choosing a nanopublication (but in fact that community does not yet exist as nanopublication. So it needs improvement, but without the mention of the super-community.
@anjuraj15 You forget to assign me reviewer in the PR ;) @rbramley I think it's because it's created from nanodash, and not the FIP wizard, the FIP wizard does not ask for maturity. Additonally, this FIC lists |
@burgerga Thank you for the comments. I am trying to understand the workflow behind the FSR qualification and sorry if I messed it up. So just to see if I got it right.. I make the changes to the CSV and once I commit the changes should I create a new pull request? |
No problem :) |
FSR_QC.csv
Outdated
@@ -17,3 +17,4 @@ | |||
352,Barbara Magagna,0000-0003-2195-3997,Darwin Core,http://purl.org/np/RAaSo_0hEIHE2SUOsdN-Y27AfIp9Kf-YI-lrvDYORo9JA#DwC,http://purl.org/np/RAaSo_0hEIHE2SUOsdN-Y27AfIp9Kf-YI-lrvDYORo9JA,"http://purl.org/np/RAdf9taM_Gyq2-WavUq3CxaVIvsHockMXzonj3W_igNhM,http://purl.org/np/RABFB5JSqq0yM8qBWjlsvMJD-w3sCnOQlw7Sdb0Oc-xmU,http://purl.org/np/RAFmqYVBtOTURhXkRP0EHLqMV5HBXa5nrvHJS9SxTmwhg",,,,,,0000-0001-8050-0299,D,,D,,N/A, | |||
147,Barbara Magagna,0000-0003-2195-3997,DEIMS-SDR_Site_Metadata_Model,http://purl.org/np/RAS95nqgBVT5tVaQiUfCwgFWjxIiwxtkZlkeMIRLDw9KU#DEIMS-SDR_SMM,http://purl.org/np/RAktO6jJg-krEZKPkHe2rZrymGybzgM-EaS2mm1TTTh10,,N,,N,Y,,F,I,"Improve label, definition with more details",I,http://purl.org/np/RAScP6OoU6ybnuVBXFumbMCg8eOGy4I6p_LUQaFo8jTPM,, | |||
423,Barbara Magagna,0000-0003-2195-3997,DataOne,http://purl.org/np/RAU2z2ehbJpnRHujQ5WnovRc2RrSI9nn6qbJ-P4OQt_sQ#DataONE,http://purl.org/np/RAo5M3uFEF2OeBUvfcXESfGBKng9zAu8M6OsKZBeSVyRY,,N,,Y,Y,,F,I,"Improve label to DataONE data management platform, change access URL to https://search.dataone.org/data",I,http://purl.org/np/RAKk8fx2D_JUEYhovoh5Jqz4-YAAq-qh81Ig14vtWFylk,, | |||
454,Anjana Elapavalore,0000-0002-0295-6618,EuBIC-MS | EuBIC-MS (European Bioinformatics Community for Mass Spectrometry),http://purl.org/np/RAM97cdpYSchgAbbj_lF70I7ecn7LeSycJ_glSqjR7Fxw#EuBIC-MS,http://purl.org/np/RAM97cdpYSchgAbbj_lF70I7ecn7LeSycJ_glSqjR7Fxw,,Y,,Y,Y,,F,A,Accept,,,, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Definition ok" should be 0 (FIC supercommunity incorrect)
"FSR creator in pubinfo (yellow): FIP Wizard (F) or the ORCID" should be Parul's ORCID
proposal should be "I" (improve)
I am checking all points, and will reply soon to what needs to happen then
…On Mon, Jan 22, 2024 at 6:31 PM anjuraj15 ***@***.***> wrote:
@burgerga <https://github.com/burgerga> Thank you for the comments. I am
trying to understand the workflow behind the FSR qualification and sorry if
I messed it up. So just to see if I got it right.. I make the changes to
the CSV and once I commit the changes should I create a new pull request?
—
Reply to this email directly, view it on GitHub
<#460 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH2WOHH75ROTCEIRW6LN7JTYP2O6VAVCNFSM6AAAAABCFPC4PCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBUGQ4DAMBUG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
*Barbara Magagna*
*FAIR Development Coordinator*
GO FAIR Foundation
E-mail: ***@***.***
Mobile: +43 69910057602
Skype: barbara.magagna
Web: www.gofair.foundation
Address:
Poortgebouw Noord
Rijnsburgerweg 10
2333 AA Leiden
The Netherlands
|
@burgerga thanks for spotting this difference, I will need to update the FIP Wizard but this is not the reason... see above
@anjuraj15 I propose instead to disapprove the nanopub and edit as derived nanopub with the identifier of the subject. I would not wait for Parul (she knows we are improving anyway) |
Updated the proposal and FSR creator in the FSR_QC.csv
updated upstream
Hi @anjuraj15, Please see Barbara's latest comment, it should now be disapproved, and edited as a derived nanopublication. |
Here are the changes in FSR_QC.csv:
|
I removed the merge conflict for you, still needs the "1. issue number" back in column 1 header though, see https://github.com/gofair-foundation/fsr_qualification/pull/460/files#r1462111530 (there you can click the 3 dots on the right side of the screen, and choose "Edit file") |
Yes, it was strange; my command line showed no conflicts while pushing the commits. I will update the FSR now. |
updated proposal
Here are the changes in FSR_QC.csv:
|
@burgerga I updated the proposal and the first column header. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, looks great!
we have done the check now and we are happy with what Anjana has done
Here are the changes in FSR_QC.csv:
|
Resolves #454
Update FSR_QC.CSV - issue 454 EuBIC-MS