Fixed linters & tests in Mongo, Solr, Badger datasources #1245
Conversation
pkg/gofr/datasource/solr/solr.go
Outdated
| // client.Connect() | ||
| func New(conf Config) *Client { | ||
| // client.Connect(). | ||
| func New(conf *Config) *Client { |
There was a problem hiding this comment.
This change is unnecessary and does not feel like a good idea. Config should not be a pointer.
There was a problem hiding this comment.
I agree.
There was a problem hiding this comment.
I was trying to be consistent across all the datasources. Some datasources that have a heavy config struct are passed by reference. So was being consistent across datasources passing each config struct by reference.
There was a problem hiding this comment.
The same point has been raised by myself, on another PR
There was a problem hiding this comment.
I don't know what should be done. I agree it's better to have a consistent say to do.
But having a pointer for a configuration looks strange, not, yes it has performance/memory issues
Pull Request Template
Description:
Checklist:
goimportandgolangci-lint.Thank you for your contribution!