-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(geo/src/coordinates): add coordinate parsing and validation #88
Conversation
9ae8239
to
fc859c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1/?
Not going to harp on it too much since things are still actively being changed which makes it annoying. But please remember to comment everything when putting the final polish on it so that we can generate adequate api docs (when the script gets moved). Will DM something internally. |
5c35a37
to
d294c50
Compare
d294c50
to
8500868
Compare
8500868
to
11e2619
Compare
What does this mean? What is it asking? |
Is this good to merge? Are there things I should change before merge? |
11e2619
to
82c7689
Compare
This is likely good to go for our first implementation pass to test things in the wild. We may end up slightly adjusting the folder/file structure but that can happen later once we have more things in |
@kalisjoshua actually one final TODO: add in the changeset |
I've been waiting for this one because I want to document it and add that to the docs. What do I need to do for that? |
Just run the |
5768c66
to
4fa4bfc
Compare
76d4172
to
5f537c1
Compare
5f537c1
to
c3e452d
Compare
closes #70