Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(geo/src/coordinates): add coordinate parsing and validation #88

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

kalisjoshua
Copy link
Contributor

@kalisjoshua kalisjoshua commented Nov 6, 2024

closes #70

@kalisjoshua kalisjoshua force-pushed the feat/76-coordinate-regex-testing branch 13 times, most recently from 9ae8239 to fc859c7 Compare November 7, 2024 20:59
Copy link
Contributor

@belsrc belsrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1/?

@belsrc
Copy link
Contributor

belsrc commented Nov 8, 2024

Not going to harp on it too much since things are still actively being changed which makes it annoying. But please remember to comment everything when putting the final polish on it so that we can generate adequate api docs (when the script gets moved). Will DM something internally.

@kalisjoshua kalisjoshua force-pushed the feat/76-coordinate-regex-testing branch 9 times, most recently from 5c35a37 to d294c50 Compare November 15, 2024 20:46
@belsrc belsrc added the feature A new feature label Nov 17, 2024
@kalisjoshua kalisjoshua force-pushed the feat/76-coordinate-regex-testing branch from d294c50 to 8500868 Compare November 19, 2024 19:59
@kalisjoshua kalisjoshua force-pushed the feat/76-coordinate-regex-testing branch from 8500868 to 11e2619 Compare November 19, 2024 20:05
@kalisjoshua
Copy link
Contributor Author

1/?

What does this mean? What is it asking?

@kalisjoshua
Copy link
Contributor Author

Is this good to merge? Are there things I should change before merge?

@kalisjoshua kalisjoshua force-pushed the feat/76-coordinate-regex-testing branch from 11e2619 to 82c7689 Compare December 2, 2024 15:08
@brandonjpierce
Copy link
Contributor

This is likely good to go for our first implementation pass to test things in the wild. We may end up slightly adjusting the folder/file structure but that can happen later once we have more things in @accelint/geo. Thanks for all of the hard work on this one!

@brandonjpierce brandonjpierce self-requested a review December 2, 2024 18:53
brandonjpierce
brandonjpierce previously approved these changes Dec 2, 2024
@brandonjpierce
Copy link
Contributor

@kalisjoshua actually one final TODO: add in the changeset

@kalisjoshua
Copy link
Contributor Author

@kalisjoshua actually one final TODO: add in the changeset

I've been waiting for this one because I want to document it and add that to the docs. What do I need to do for that?

@belsrc
Copy link
Contributor

belsrc commented Dec 2, 2024

Just run the changeset script in the root package file. It will run an interactive CLI that walks you through it. Will pick which packages were changed, which (if any) were major. Will pick which packages were changed, which (if any) were minor. Will pick which packages were changed, which (if any) were patch. And will enter a description of change. Once done, it will create a markdown file of what you entered.

@kalisjoshua kalisjoshua force-pushed the feat/76-coordinate-regex-testing branch 2 times, most recently from 5768c66 to 4fa4bfc Compare December 2, 2024 19:44
@kalisjoshua kalisjoshua force-pushed the feat/76-coordinate-regex-testing branch 2 times, most recently from 76d4172 to 5f537c1 Compare December 2, 2024 20:34
@kalisjoshua kalisjoshua force-pushed the feat/76-coordinate-regex-testing branch from 5f537c1 to c3e452d Compare December 2, 2024 20:37
@brandonjpierce brandonjpierce merged commit 6c23f31 into main Dec 2, 2024
3 checks passed
@brandonjpierce brandonjpierce deleted the feat/76-coordinate-regex-testing branch December 2, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finish coordinate suite
3 participants