Fix some issues found by lint #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joonas-fi
commented
Mar 4, 2022
joonas-fi
commented
Mar 4, 2022
joonas-fi
commented
Mar 4, 2022
|
Oh sorry, I I just now noticed that you wrote:
I fixed some of them 🤦 I'll of course revert anything that you think is not worth the trouble. |
stapelberg
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #10
I fixed only what I think are "uncontroversial", i.e. I didn't yet mark any "lint ignore" annotations for more aggressive/"controversial" linters, because we don't yet have any agreed-on linter configuration.
Each commit explains what I fixed.
If you prefer, I can squash the commits before merging.