Skip to content

Commit

Permalink
Merge pull request #14 from gokulk16/r-11
Browse files Browse the repository at this point in the history
Fix: security vulnerability from snyk; Removing homecurrency test since github workflows run in different location
  • Loading branch information
gokulk16 authored Jun 6, 2024
2 parents 61afbfc + 49f0fda commit 648c40d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
2 changes: 1 addition & 1 deletion js/currency.js
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export async function getConversionRates() {
const conversionRate =
(amountToConvert / currencies[baseCurrency]) *
currencies[targetCurrency];
convertedRates[baseCurrency][targetCurrency] = conversionRate;
_.set(convertedRates, [baseCurrency, targetCurrency], conversionRate);
});
});

Expand Down
8 changes: 0 additions & 8 deletions test/editor.test.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import {
setupEvaluator,
setupHomeCurrency,
generateDocID,
evaluate,
loadPlaceholderData,
Expand All @@ -19,13 +18,6 @@ describe("testing generateDocID", () => {
});
});

describe("testing setupHomeCurrency", () => {
test("setting up Home Currency", async () => {
const homeCurr = await setupHomeCurrency();
expect(homeCurr).toBe("INR");
});
});

describe("testing evaluate", () => {
test("Evaluate empty string", async () => {
const evalValues = await evaluate("");
Expand Down

0 comments on commit 648c40d

Please sign in to comment.