Add ON CLUSTER {cluster} support for clickhouse queries
#1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Useless pull request after all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add support for ON CLUSTER queries. This will replace any
ON CLUSTER {cluster}string in a sql query byON CLUSTER <clusterName that was provided in x-cluster-name>. Replacing the{cluster}string has been chosen has this looks like a clickhouse macro that can be used somewhere else inCREATEqueries for example. This way it's consistent with the rest. The drawback is that this may mislead some users as they might think this is a macro that can be replace by clickhouse directly but it's not (unfortunately).All tests pass: