edge_distances: fix test #106
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@missinglink for us to merge this PR, we need a signed CLA. Could you please check out the failing check above? Thanks! |
|
|
You have a CLA signed under |
The fixture for this test case is confusing, it seems to 'want' `false` but actually it is being ignored and the test is assertion for `true`.
|
| @@ -202,26 +202,26 @@ func TestEdgeDistancesUpdateMinInteriorDistanceRejectionTestIsConservative(t *te | |||
| a: Point{r3.Vector{1, -8.9031850507928352e-11, 0}}, | |||
| b: Point{r3.Vector{-0.99999999999996347, 2.7030110029169596e-07, 1.555092348806121e-99}}, | |||
| minDist: minDist, | |||
| want: false, | |||
| want: true, | |||
There was a problem hiding this comment.
Confirmed true agrees with C++.
@rsned Maybe we should just delete the want field, since it's always true.
There was a problem hiding this comment.
We should probably come up with At least one test case that should be false just to be sure things actually do as they claim.
The fixture for this test case is confusing, it seems to 'want'
falsebut actually it is being ignored and the test is expectingtrue.