-
Notifications
You must be signed in to change notification settings - Fork 18k
net: rework the CNAME handling on unix #57093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
net: rework the CNAME handling on unix #57093
Conversation
This PR (HEAD: d53187d) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/455275 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: c73cb25) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/455275 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 4f7f78d) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/455275 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: a431ad1) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/455275 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: f6b504c) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/455275 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 445464f) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/455275 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 4b78ce8) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/455275 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 32f3d80) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/455275 to see it. Tip: You can toggle comments from me using the |
Message from Damien Neil: Patch Set 9: Run-TryBot+1 (11 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
Message from Gopher Robot: Patch Set 9: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
Message from Gopher Robot: Patch Set 9: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
Message from Gopher Robot: Patch Set 9: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
This PR (HEAD: 4a0bf94) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/455275 to see it. Tip: You can toggle comments from me using the |
Message from Mateusz Poliwczak: Patch Set 9: (6 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
Message from Mateusz Poliwczak: Patch Set 10: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
This PR (HEAD: a62373d) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/455275 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 3c7399a) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/455275 to see it. Tip: You can toggle comments from me using the |
Message from Mateusz Poliwczak: Patch Set 11: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
This PR (HEAD: 106b173) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/455275 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 1ab00b0) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/455275 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 12a97e0) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/455275 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 2f47ddd) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/455275 to see it. Tip: You can toggle comments from me using the |
2f47ddd
to
71b99f1
Compare
This PR (HEAD: 71b99f1) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/455275 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 579098c) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/455275 to see it. Tip: You can toggle comments from me using the |
Message from [email protected]: Patch Set 18: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
Message from [email protected]: Patch Set 19: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
Message from Mateusz Poliwczak: Patch Set 19: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
Message from Gopher Robot: Patch Set 19: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
Message from Gopher Robot: Patch Set 19: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
effb49f
to
b3c5526
Compare
This PR (HEAD: b3c5526) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/455275. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 69: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
Message from Gopher Robot: Patch Set 69: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
Message from Gopher Robot: Patch Set 69: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
b3c5526
to
af47818
Compare
This PR (HEAD: af47818) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/455275. Important tips:
|
af47818
to
624c0e1
Compare
This PR (HEAD: 624c0e1) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/455275. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 71: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
Message from Gopher Robot: Patch Set 71: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
Message from Gopher Robot: Patch Set 71: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
624c0e1
to
b563c03
Compare
This PR (HEAD: b563c03) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/455275. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 72: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
Message from Gopher Robot: Patch Set 72: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
Message from Gopher Robot: Patch Set 72: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
b563c03
to
b7ff797
Compare
This PR (HEAD: b7ff797) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/455275. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 73: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
Message from Gopher Robot: Patch Set 73: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
Message from Gopher Robot: Patch Set 73: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
b7ff797
to
41bc1ff
Compare
This PR (HEAD: 41bc1ff) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/455275. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 74: Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
Message from Gopher Robot: Patch Set 74: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
Message from Ian Lance Taylor: Patch Set 74: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
Message from Gopher Robot: Patch Set 74: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
Message from Mateusz Poliwczak: Patch Set 74: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
This change reworks the LookupCNAME handling:
when cgoLookupCNAME faills (even noSuchHosts), this
also implies using the canonical name from getaddrinfo.
returning proper &DNSError to match the go resolver behaviour and
detecting the noSuchHost condition.
not the first one.
More details about current issues are described in #59943.
Fixes #59943
Updates #50101