Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
cmd/gobind: do not compile package just to find package dir
Gobind utilizes golang.org/x/tools/go/packages.Load to find the directory of a package. Configure the load configuration to just find the list of files. Zero load mode is equivalent to combining NeedName+NeedFiles+NeedCompiledGoFiles bits. That is unnecessary, and can increase the chance of load failures. For example, load with the zero load mode may fail if all the necessary cgo dependencies aren't available in the system, but that shouldn't be critical for gobind's use case. Updates golang/go#56292 Change-Id: Ifaf4f43e9053cf4a43fd657a9a394fc13f611576 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/443935 Reviewed-by: David Chase <[email protected]> Reviewed-by: Bryan Mills <[email protected]> Reviewed-by: Hajime Hoshi <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
- Loading branch information