JSON unmarshaler returns UnknownFieldError error #250
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the JSON unmarshaler return a new error struct, UnknownFieldError, for unknown fields, when
AllowUnknownFields
isfalse
. This is necessary in order for callers to be able to hide Go internals in APIs. Previously, the error ofUnmarshal
would be an error string such as:This leaks the type
proto.Mutation
to clients, which should not need to see such internals when they are consuming a pure-JSON HTTP API.There are other instances of
fmt.Errorf
being used, but this is the main one that leaks.