gopls/internal/codeaction: replace all occurrences of expression (refactor.extract.variable.all) #539

xzbdmw · 2024-10-31T17:32:36Z

This change introduces a new refactoring code action
"Extract n occurrences of expression".

The original "Extract Variable" is treated as a limited version
of "Extract n occurrences of expression", they share the same
underlying implementation. The difference is that
"extract_all" utilizes a slice of structural equal expression
by searching through the entire function body, while the limited
version simply append the expression under selection to that slice.

Also:

change default variable name from "x" to "newVar",
users will almost always perform a rename after
extraction, so this change make it more discoverable.
add marker test extract_expressions.txt and
extract_expressions_resolve.txt.

Updates golang/go#70085

gopherbot · 2024-10-31T17:45:29Z

This PR (HEAD: 4e59087) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-10-31T18:00:38Z

This PR (HEAD: 00f4d8a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-01T07:41:52Z

This PR (HEAD: 2eeb2c4) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-01T08:58:34Z

This PR (HEAD: 0c4ddaf) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-01T09:26:03Z

This PR (HEAD: 2f839f4) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-01T10:28:39Z

This PR (HEAD: 78461fc) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-01T11:41:56Z

This PR (HEAD: 0324b69) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-01T11:58:40Z

This PR (HEAD: 83f4dc3) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-01T12:32:57Z

This PR (HEAD: 8581970) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-01T18:18:50Z

This PR (HEAD: 51938d2) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-02T07:24:52Z

This PR (HEAD: f935517) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-02T09:48:40Z

This PR (HEAD: 26fbd88) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-04T07:54:36Z

Message from xxx Lulu:

Patch Set 20:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/624035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-04T16:26:14Z

This PR (HEAD: 5dcd92b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-08T21:27:54Z

This PR (HEAD: 79bdd50) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-14T18:10:17Z

This PR (HEAD: 6cec9c5) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-15T06:02:24Z

This PR (HEAD: 81352ac) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-18T22:42:59Z

This PR (HEAD: 659733b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-20T19:38:12Z

Message from Alan Donovan:

Patch Set 25:

(14 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/624035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-21T09:58:52Z

This PR (HEAD: 9c617a3) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-21T10:07:00Z

Message from xxx Lulu:

Patch Set 25:

(14 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/624035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-22T18:14:50Z

Message from Robert Findley:

Patch Set 26:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/624035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-22T19:06:04Z

Message from xxx Lulu:

Patch Set 26:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/624035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-23T16:07:12Z

This PR (HEAD: be697e0) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-24T10:09:34Z

This PR (HEAD: 0798b03) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-24T10:16:59Z

This PR (HEAD: a0a7d04) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

new test

gopherbot · 2024-11-24T10:34:22Z

This PR (HEAD: 8443b23) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/624035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-24T10:41:09Z

Message from xxx Lulu:

Patch Set 29:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/624035.
After addressing review feedback, remember to publish your drafts!

xzbdmw changed the title ~~gopls/internal/codeaction: Replace All Occurrences of Expression~~ gopls/internal/codeaction: Replace all occurrences of expression Oct 31, 2024

xzbdmw changed the title ~~gopls/internal/codeaction: Replace all occurrences of expression~~ gopls/internal/codeaction: replace all occurrences of expression ("refactor.extract.variable.all") Oct 31, 2024

xzbdmw changed the title ~~gopls/internal/codeaction: replace all occurrences of expression ("refactor.extract.variable.all")~~ gopls/internal/codeaction: replace all occurrences of expression (refactor.extract.variable.all) Oct 31, 2024

xzbdmw force-pushed the replace_all branch from 44bfbc7 to 4e59087 Compare October 31, 2024 17:42

xzbdmw force-pushed the replace_all branch from 4e59087 to 00f4d8a Compare October 31, 2024 17:53

xzbdmw force-pushed the replace_all branch from 00f4d8a to 2eeb2c4 Compare November 1, 2024 07:41

xzbdmw force-pushed the replace_all branch from 2eeb2c4 to 0c4ddaf Compare November 1, 2024 08:51

xzbdmw force-pushed the replace_all branch from 0c4ddaf to 2f839f4 Compare November 1, 2024 09:25

xzbdmw force-pushed the replace_all branch from 2f839f4 to 78461fc Compare November 1, 2024 10:24

xzbdmw force-pushed the replace_all branch 2 times, most recently from 30abec2 to 0324b69 Compare November 1, 2024 11:37

xzbdmw force-pushed the replace_all branch 3 times, most recently from 37c7b7b to 83f4dc3 Compare November 1, 2024 11:57

xzbdmw force-pushed the replace_all branch from 83f4dc3 to 8581970 Compare November 1, 2024 12:25

xzbdmw force-pushed the replace_all branch from 8581970 to 51938d2 Compare November 1, 2024 18:15

xzbdmw force-pushed the replace_all branch from 51938d2 to f935517 Compare November 2, 2024 07:18

xzbdmw force-pushed the replace_all branch from f935517 to 26fbd88 Compare November 2, 2024 09:44

xzbdmw force-pushed the replace_all branch from 9bcac7f to 5dcd92b Compare November 4, 2024 16:20

xzbdmw force-pushed the replace_all branch from 5dcd92b to 79bdd50 Compare November 8, 2024 21:25

xzbdmw force-pushed the replace_all branch from 79bdd50 to 6cec9c5 Compare November 14, 2024 18:06

xzbdmw force-pushed the replace_all branch 2 times, most recently from b40c319 to 81352ac Compare November 15, 2024 05:56

xzbdmw force-pushed the replace_all branch from 81352ac to 659733b Compare November 18, 2024 22:40

xzbdmw force-pushed the replace_all branch 3 times, most recently from fb7dd04 to 9c617a3 Compare November 21, 2024 09:54

xzbdmw force-pushed the replace_all branch from 9c617a3 to be697e0 Compare November 23, 2024 16:00

xzbdmw force-pushed the replace_all branch from be697e0 to 0798b03 Compare November 24, 2024 10:02

xzbdmw force-pushed the replace_all branch from 0798b03 to a0a7d04 Compare November 24, 2024 10:10

replace_all

8443b23

new test

xzbdmw force-pushed the replace_all branch from a0a7d04 to 8443b23 Compare November 24, 2024 10:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gopls/internal/codeaction: replace all occurrences of expression (refactor.extract.variable.all) #539

gopls/internal/codeaction: replace all occurrences of expression (refactor.extract.variable.all) #539

xzbdmw commented Oct 31, 2024 •

edited

Loading

gopherbot commented Oct 31, 2024

gopherbot commented Oct 31, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 2, 2024

gopherbot commented Nov 2, 2024

gopherbot commented Nov 4, 2024

gopherbot commented Nov 4, 2024

gopherbot commented Nov 8, 2024

gopherbot commented Nov 14, 2024

gopherbot commented Nov 15, 2024

gopherbot commented Nov 18, 2024

gopherbot commented Nov 20, 2024

gopherbot commented Nov 21, 2024

gopherbot commented Nov 21, 2024

gopherbot commented Nov 22, 2024

gopherbot commented Nov 22, 2024

gopherbot commented Nov 23, 2024

gopherbot commented Nov 24, 2024

gopherbot commented Nov 24, 2024

gopherbot commented Nov 24, 2024

gopherbot commented Nov 24, 2024

gopls/internal/codeaction: replace all occurrences of expression (refactor.extract.variable.all) #539

Are you sure you want to change the base?

gopls/internal/codeaction: replace all occurrences of expression (refactor.extract.variable.all) #539

Conversation

xzbdmw commented Oct 31, 2024 • edited Loading

gopherbot commented Oct 31, 2024

gopherbot commented Oct 31, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 1, 2024

gopherbot commented Nov 2, 2024

gopherbot commented Nov 2, 2024

gopherbot commented Nov 4, 2024

gopherbot commented Nov 4, 2024

gopherbot commented Nov 8, 2024

gopherbot commented Nov 14, 2024

gopherbot commented Nov 15, 2024

gopherbot commented Nov 18, 2024

gopherbot commented Nov 20, 2024

gopherbot commented Nov 21, 2024

gopherbot commented Nov 21, 2024

gopherbot commented Nov 22, 2024

gopherbot commented Nov 22, 2024

gopherbot commented Nov 23, 2024

gopherbot commented Nov 24, 2024

gopherbot commented Nov 24, 2024

gopherbot commented Nov 24, 2024

gopherbot commented Nov 24, 2024

xzbdmw commented Oct 31, 2024 •

edited

Loading