Add linter asasalint to lint pass []any as any

[alingse]

Linter

the linter asasalint aim to lint bug about pass []any as any in variadic function

i have check some top go repos in github, and the found bugs list in the issues: alingse/asasalint#1

and more failed in check on github actions (some is not the bug)

User

the linter may wrong report some not bug lint,

user can add exclude to avoid some wrong report

[CLAassistant]

All committers have signed the CLA.

[boring-cyborg]

Hey, thank you for opening your first Pull Request !

[ldez]

In order for a pull request adding a linter to be reviewed, the linter and the PR must follow some requirements.

Pull Request Description

• It must have a link to the linter repository.
• It must provide a short description about the linter.

Linter

• It must not be a duplicate of another linter or a rule of a linter. (the team will help to verify that)
• It must have a valid license and the file must contain the required information by the license, ex: author, year, etc.
• It must use go/analysis.
• It must have a valid tag, ex: v1.0.0, v0.1.0.
• It must not contain init().
• It must not contain panic(), log.fatal(), os.exit(), or similar.
• It must not have false positives/negatives. (the team will help to verify that)
• It must have tests inside golangci-lint.

The Linter Tests Inside Golangci-lint

• They must have at least one std lib import.
• They must work with T=<name of the linter test file>.go make test_linters. (the team will help to verify that)

.golangci.example.yml

• The linter must be added to the list of available linters (alphabetical case-insensitive order).
  • enable and disable options
• If the linter has a configuration, the exhaustive configuration of the linter must be added (alphabetical case-insensitive order)
  • The values must be different from the default ones.
  • The default values must be defined in a comment.
  • The option must have a short description.

Others Requirements

• The files (tests and linter) inside golangci-lint must have the same name as the linter.
• The .golangci.yml of golangci-lint itself must not be edited and the linter must not be added to this file.
• The linters must be sorted in the alphabetical order (case-insensitive) in the Manager.GetAllSupportedLinterConfigs(...) and .golangci.example.yml.
• The load mode (WithLoadMode(...)):
  • if the linter doesn't use types: goanalysis.LoadModeSyntax
  • goanalysis.LoadModeTypesInfo required WithLoadForGoAnalysis() in the Manager.GetAllSupportedLinterConfigs(...)
• The version in WithSince(...) must be the next minor version (v1.X.0) of golangci-lint.

Recommendations

• The linter should not use SSA. (currently, SSA does not support generics)
• The linter repository should have a CI, tests, a readme and linting.
• The linter should be published as a binary (useful to diagnose bug origins). We recommend goreleaser.

---

The golangci-lint team will edit this comment to check the boxes before and during the review.

This checklist does not imply that we will accept the linter.

[ldez]

I would also recommend not using a GitHub organization to manage forks to create PRs: GitHub doesn't allow maintainers to edit the content of a PR from an organization.
This is a problem for maintainers if they have to edit your PRs and for automation that modifies or updates PRs.

[ldez]

The suggestions should be managed through GitHub:

• https://docs.github.com/cn/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/incorporating-feedback-in-your-pull-request
• https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/incorporating-feedback-in-your-pull-request

[alingse]

first, i run T=asasalint.go make test_linters not show the real error msg, because the exce in test was killed, and exitcode is -1.
after run the test on cloud instance. i find, the miss match is beacuse // ERROR regex part, and any is not available in go1.17, and interface{} should be interface\{\}.

every review applied and CI fixed (maybe).

the releaser is also done for asasalint.

[ldez]

please add commit instead of push force

[alingse]

please add commit instead of push force

ok, sorry for that. next linter will be ok.

[ldez]

@kamilsk I don't check those boxes because they are the last things that I check.

It doesn't mean something for now.

[ldez]

@alingse can you rebase your PR and update the tests to use the new syntax from #2978?

Once again, as your PR comes from a GitHub organization I'm not able to update your PR, I really recommend not using a GitHub organization to manage forks.

[alingse]

@ldez ok, i will close this and reopen new one with new syntax for test.

[alingse]

@ldez i have transfer the ownship to alingse now, can you edit now? and i have upgrade to 0.0.7 to add one miss builtin exclude Sprint.

local test pass

 T=asasalint.go make test_linters
GL_TEST_RUN=1 go test -v ./test -count 1 -run TestSourcesFromTestdataWithIssuesDir/asasalint.go


=== RUN   TestSourcesFromTestdataWithIssuesDir
    linters_test.go:44: testdata/*.go
=== RUN   TestSourcesFromTestdataWithIssuesDir/asasalint.go
=== PAUSE TestSourcesFromTestdataWithIssuesDir/asasalint.go
=== CONT  TestSourcesFromTestdataWithIssuesDir/asasalint.go
    linters_test.go:237: [run --go=1.17 --allow-parallel-runners --disable-all --print-issued-lines=false --out-format=line-number --max-same-issues=100 -Easasalint --no-config testdata/asasalint.go]
    linters_test.go:237: [run --go=1.17 --allow-parallel-runners --disable-all --print-issued-lines=false --out-format=line-number --max-same-issues=100 -Easasalint -Etypecheck --no-config testdata/asasalint.go]
--- PASS: TestSourcesFromTestdataWithIssuesDir (7.83s)
    --- PASS: TestSourcesFromTestdataWithIssuesDir/asasalint.go (3.41s)
PASS
ok  	github.com/golangci/golangci-lint/test	12.059s

[ldez]

@alingse I am still not able to edit your PR, can you check the box:

and validate the fork configuration.

[alingse]

@ldez done.

[alingse]

LGTM

[ldez]

LGTM