Fix kubeVersion in Chart.yaml to support EKS and other 'non-standard' K8S versions #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… versions Currently `kubeVersion` is only allowing standard semver compatible versions like `v1.29.11` for example. In many cases however, such as when running on EKS, you'll have a version like `v1.28.5-eks-5e0fdde` which when run with `helm template --validate` produces an error: ``` $ helm template athens athens/athens-proxy --version ~0.14.0 --namespace athens --values values.yaml --validate --is-upgrade Error: chart requires kubeVersion: >= 1.19 which is incompatible with Kubernetes v1.28.5-eks-5e0fdde ``` This change should fix the issue by opening up the version constraint slightly to support 'pre-release' versions as suggested here: - helm/helm#10375 (comment) (suggested change) - helm/helm#10375 (comment) (EKS's response for the curious) - https://helm.sh/docs/chart_template_guide/function_list/#working-with-prerelease-versions
DrPsychick
approved these changes
Sep 24, 2024
|
You're welcome! Yeah that was a bit of a weird one. I guess on the one hand it's technically correct to ignore pre-release versions since that's how semver works but almost every hosted version of K8S that I know of uses a version scheme like Any estimates on when a |
|
Hey @opalmer , I intend to do a release once the two small PRs are reviewed and merged - I expect this week. |
|
Awesome, thank you!
…On Wed, Sep 25, 2024, 7:40 AM DrPsychick ***@***.***> wrote:
Hey @opalmer <https://github.com/opalmer> , I intend to do a release once
the two small PRs are reviewed and merged - I expect this week.
—
Reply to this email directly, view it on GitHub
<#88 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB6JDNOF64H6JBRMDNCURLZYKOL5AVCNFSM6AAAAABOWR6DI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZTHA2DGNBUHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
kubeVersionis only allowing standard semver compatible versions likev1.29.11for example. In many cases however, such as when running on EKS, you'll have a version likev1.28.5-eks-5e0fddewhich when run withhelm template --validateproduces an error:This change should fix the issue by opening up the version constraint slightly to support 'pre-release' versions as suggested here: