Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use https if proxied #2033

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

swills
Copy link

@swills swills commented Feb 18, 2025

What is the problem I am trying to address?

I have athens deployed in k8s with the service on http and an ingress on https. The home page is displaying an http URL, which is incorrect. Not a huge deal, but I think this will fix it. Haven't tested yet, wanted to run this by you and see if it makes sense before going to all the trouble of setting up the builds and testing, since it's a simple one liner.

How is the fix applied?

I think (hope) all that's needed is this one line change.

What GitHub issue(s) does this PR fix or close?

I didn't make an issue for this, but I could if you want.

@swills swills requested a review from a team as a code owner February 18, 2025 16:20
@matt0x6F
Copy link
Contributor

The intent behind this feature was to completely replace the template for the home page, although, I kind of think we shouldn't have included a default because it can be confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants