Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify cmake output folders #2904

Merged
merged 2 commits into from
Feb 8, 2025
Merged

Conversation

Morilli
Copy link
Contributor

@Morilli Morilli commented Feb 1, 2025

Building with different generators on different operation systems could result in different output directories being used for build output, which was confusing and hinders automatic build systems.

Previous output paths:

Ninja generator; Release config on windows:
build/

Ninja generator; Debug config on windows:
build/

Ninja generator; Release config not on windows:
build/plugin/Release/

Ninja generator; Debug config not on windows:
build/plugin/Debug/

MSVC generator on windows (similar for other multi-config generators):
build/{MSVC config}/

New output paths:

Ninja generator; Release config on windows:
build/plugin/Release/

Ninja generator; Debug config on windows:
build/plugin/Debug/

Ninja generator; Release config not on windows:
build/plugin/Release/

Ninja generator; Debug config not on windows:
build/plugin/Debug/

MSVC generator on windows (similar for other multi-config generators):
build/plugin/{MSVC config}/

Copy link
Owner

@gonetz gonetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@gonetz gonetz merged commit 17d9703 into gonetz:master Feb 8, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants