Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enforce procedure deletion validation #107

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

gonfunko
Copy link
Owner

@gonfunko gonfunko commented Aug 5, 2024

This PR updates the procedure deletion handling code to run when checkAndDelete is called on the procedure definition block, rather than looking for the "Delete Block" menu item by title and removing and replacing it.

src/procedures.js Show resolved Hide resolved
@gonfunko gonfunko merged commit 936967b into modern-blockly Aug 6, 2024
1 check passed
@gonfunko gonfunko deleted the procedure-deletion branch August 6, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants