Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add support for flyout labels with status indicators #212

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

gonfunko
Copy link
Owner

@gonfunko gonfunko commented Oct 7, 2024

This PR adds a FlyoutButton subclass that adds a status indicator icon, along with an associated inflater. The toolbox and category are also updated to populate these in the intermediate representation of the flyout contents, because the continuous toolbox synthesizes labels for each toolbox category and injects them in between the blocks for each category. This fixes #7.

Copy link
Collaborator

@rachel-fenichel rachel-fenichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once you add docs in status_indicator_label.js

src/status_indicator_label.js Show resolved Hide resolved
@gonfunko gonfunko merged commit 665d196 into modern-blockly Oct 14, 2024
1 check passed
@gonfunko gonfunko deleted the status-indicators branch October 14, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement extension category headers
2 participants