Skip to content

Commit

Permalink
Extend options (#2)
Browse files Browse the repository at this point in the history
* Extend options

* Mark fields as required.

* Provide fallback for empty options

* Build new version

* update readme

Co-authored-by: David Schovanec <[email protected]>
  • Loading branch information
gonuit and schovi authored Sep 9, 2020
1 parent acde98d commit 9ac1c7b
Show file tree
Hide file tree
Showing 8 changed files with 230 additions and 186 deletions.
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,12 @@ jobs:

# Name of the heroku application to which the build is to be sent.
heroku_app_name: ${{ secrets.HEROKU_APP_NAME }}

# Dokerfile name. Optional, by default will be set to "Dockerfile".
dockerfile_name: Dockerfile

# Additional options of docker build command. (Optional)
docker_options: "--no-cache"

# Dokerfile directory.
# For example, if you have a Dockerfile in the root of your project, leave it as follows:
Expand Down
6 changes: 6 additions & 0 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@ inputs:
dockerfile_directory:
description: "Dokerfile directory."
required: true
dockerfile_name:
description: "Dokerfile name. [default=Dockerfile]"
required: false
docker_options:
description: "Additional options of docker build command"
required: false
branding:
icon: server
color: purple
Expand Down
4 changes: 3 additions & 1 deletion dist/heroku/build_docker_image.d.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
export declare const buildDockerImage: ({ dockerFilePath, herokuAppName, }: {
export declare const buildDockerImage: ({ dockerfileName, dockerFilePath, dockerOptions, herokuAppName, }: {
dockerfileName: string;
dockerFilePath: string;
dockerOptions?: string | undefined;
herokuAppName: string;
}) => Promise<boolean>;
Loading

0 comments on commit 9ac1c7b

Please sign in to comment.