Skip to content

Commit

Permalink
πŸ› Fixed sticky "Unsaved changes" modal when leaving editor
Browse files Browse the repository at this point in the history
no issue
- the unsaved changes confirmation modal could re-appear after leaving the editor and re-opening the same post
- remove the `.finally` which assumed the confirm action returns a promise so that the modal is properly closed
  • Loading branch information
kevinansfield committed Jan 21, 2019
1 parent bcd8f48 commit e73920e
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions app/components/modal-leave-editor.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,8 @@ import RSVP from 'rsvp';
export default ModalComponent.extend({
actions: {
confirm() {
this.confirm().finally(() => {
this.send('closeModal');
});
this.confirm();
this.send('closeModal');
}
},

Expand Down

0 comments on commit e73920e

Please sign in to comment.