-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated quickstarts/Prompting.ipynb
to use google-genai sdk
#564
base: main
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@ROHANDWIVEDI2005 Thanks for the submission. I am finally back from my sick leave and found the time to review it. I just added a couple of minor comments to make the notebook easier to understand and to maintain. Can you also check the lint and format failures and fix them (format is likely because you haven't run the formatting script, lint because a "we" needs to be changed into a "you"). And last thing, before you run the formatting script, can you also run all the cells to make sure everything works as expected? Thanks again! |
@ROHANDWIVEDI2005 Are you on Mac or windows? I think the script only works on Linux, but you don't really need to run this one locally, you can just see the output here: https://github.com/google-gemini/cookbook/actions/runs/14042477922/job/39361014933?pr=564 (and as you can see it's OK) |
View / edit / reply to this conversation on ReviewNB Giom-V commented on 2025-03-25T10:55:33Z Line #4. contents = ["Give me python code to sort a list"] Really small nitpicking (we should only fix it if there's something else to fix as well): The brackets are useless here. |
View / edit / reply to this conversation on ReviewNB Giom-V commented on 2025-03-25T10:55:34Z Line #2. model ='gemini-2.0-flash', You should use |
View / edit / reply to this conversation on ReviewNB Giom-V commented on 2025-03-25T10:55:35Z Line #2. MODEL_ID="gemini-2.0-flash" # @param ["gemini-2.0-flash-lite","gemini-2.0-flash","gemini-2.0-pro-exp-02-05"] {"allow-input":true, isTemplate: true} You don't need to redefine the |
@ROHANDWIVEDI2005 Thanks for the quick update after yesterday's feedback. It's looks well but I just added some minor comments. |
please take a look |
I have also edited a markdown for setting temperature in the new sdk pls take a look and let me know if any changes are required