Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated quickstarts/Prompting.ipynb to use google-genai sdk #564

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

ROHANDWIVEDI2005
Copy link
Contributor

I have also edited a markdown for setting temperature in the new sdk pls take a look and let me know if any changes are required

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:quickstarts Issues/PR referencing quickstarts folder labels Mar 14, 2025
@Giom-V
Copy link
Collaborator

Giom-V commented Mar 24, 2025

@ROHANDWIVEDI2005 Thanks for the submission. I am finally back from my sick leave and found the time to review it.

I just added a couple of minor comments to make the notebook easier to understand and to maintain.

Can you also check the lint and format failures and fix them (format is likely because you haven't run the formatting script, lint because a "we" needs to be changed into a "you").

And last thing, before you run the formatting script, can you also run all the cells to make sure everything works as expected?

Thanks again!

@ROHANDWIVEDI2005
Copy link
Contributor Author

I have made all the changes you requested and after running the notebook everything works as expected,
also, Is the nblint tool still broken? it dosent work when I run it locally
Screenshot 2025-03-24 232617

@Giom-V
Copy link
Collaborator

Giom-V commented Mar 25, 2025

I have made all the changes you requested and after running the notebook everything works as expected, also, Is the nblint tool still broken? it dosent work when I run it locally !

@ROHANDWIVEDI2005 Are you on Mac or windows? I think the script only works on Linux, but you don't really need to run this one locally, you can just see the output here: https://github.com/google-gemini/cookbook/actions/runs/14042477922/job/39361014933?pr=564 (and as you can see it's OK)

Copy link

review-notebook-app bot commented Mar 25, 2025

View / edit / reply to this conversation on ReviewNB

Giom-V commented on 2025-03-25T10:55:33Z
----------------------------------------------------------------

Line #4.        contents = ["Give me python code to sort a list"]

Really small nitpicking (we should only fix it if there's something else to fix as well): The brackets are useless here.


Copy link

review-notebook-app bot commented Mar 25, 2025

View / edit / reply to this conversation on ReviewNB

Giom-V commented on 2025-03-25T10:55:34Z
----------------------------------------------------------------

Line #2.        model ='gemini-2.0-flash',

You should use MODEL_ID here


Copy link

review-notebook-app bot commented Mar 25, 2025

View / edit / reply to this conversation on ReviewNB

Giom-V commented on 2025-03-25T10:55:35Z
----------------------------------------------------------------

Line #2.    MODEL_ID="gemini-2.0-flash" # @param ["gemini-2.0-flash-lite","gemini-2.0-flash","gemini-2.0-pro-exp-02-05"] {"allow-input":true, isTemplate: true}

You don't need to redefine the MODEL_ID each time, just keep one selector at the beginning of the notebook.


@Giom-V
Copy link
Collaborator

Giom-V commented Mar 25, 2025

@ROHANDWIVEDI2005 Thanks for the quick update after yesterday's feedback. It's looks well but I just added some minor comments.

@Giom-V Giom-V self-assigned this Mar 25, 2025
@ROHANDWIVEDI2005
Copy link
Contributor Author

please take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:quickstarts Issues/PR referencing quickstarts folder status:awaiting review PR awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants