Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update System_instructions.ipynb to new Python SDK #580

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

prajwxlk
Copy link

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:quickstarts Issues/PR referencing quickstarts folder labels Mar 18, 2025
@Giom-V
Copy link
Collaborator

Giom-V commented Mar 25, 2025

Thanks for the submission @prajwxlk.

I just added a couple of minor comments to make the notebook easier to understand and to maintain.

Can you also check the lint and format failures and fix them (format is likely because you haven't run the formatting script, lint because a "we" needs to be changed into a "you"). I think there's a mistake with the Lint script at the moment, You can ignore the errors reported from other notebooks.

And last thing, before you run the formatting script, can you also run all the cells to make sure everything works as expected?

Thanks again!

@Giom-V Giom-V self-assigned this Mar 25, 2025
@prajwxlk
Copy link
Author

Hello @Giom-V,

Thank you for reviewing my PR! I have implemented the changes you have asked me to do and then successfully ran the formatting script. I checked with the Lint script and it passes for this notebook successfully. I have also checked that all the cells run successfully as well.

Again thank you for providing detailed guide about the changes that had to be made, was very helpful indeed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:quickstarts Issues/PR referencing quickstarts folder status:awaiting review PR awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants