Updated examples/Voice_memos.ipynb to use google-genai SDK #593
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
github-actions
bot
added
status:awaiting review
| @@ -6,12 +6,12 @@ | |||
| "id": "Tce3stUlHN0L" | |||
There was a problem hiding this comment.
| @@ -6,12 +6,12 @@ | |||
| "id": "Tce3stUlHN0L" | |||
There was a problem hiding this comment.
Line #4. model="gemini-2.0-flash",
Can you add a "MODEL_ID" variable like this?
MODEL_ID="gemini-2.0-flash" # @param ["gemini-2.0-flash-lite","gemini-2.0-flash","gemini-2.0-pro-exp-02-05"] {"allow-input":true, isTemplate: true}
As it would make the notebook easier to maintain in the future.
Reply via ReviewNB
|
Thanks @Chamikajaya for the submission and sorry for the delayed review. Sadly that file was already being worked on in #589 and since the other PR is older I tend to give it priority (that's a rule that's as good as any other I guess). That said, since feedback is the best way to improve, I just added a couple of minor comments to make the notebook easier to understand and to maintain. I'll close the PR for now, but if for some reason #589 does not progress I'll reopen this one. |
|
I'm really sorry Giom-V, I'll make sure to do a thorough check before creating a new PR. Thank you for the feedback! |
No description provided.