Replace uses of jnp.array in types with jnp.ndarray.
#860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_559395725
branch
from
b344e64 to
c04f787
Compare
copybara-service
bot
force-pushed
the
test_559395725
branch
from
c04f787 to
66e58c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace uses of
jnp.arrayin types withjnp.ndarray.jnp.arrayis a function, not a type:https://jax.readthedocs.io/en/latest/_autosummary/jax.numpy.array.html
so it never makes sense to use
jnp.arrayin a type annotation. Presumably the intent was to writejnp.ndarrayakajax.Array.