Fix timesfm incompatibility with conda environment due different pip … #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…semantic naming Fixes google-research#244 Installation of timefs results to installing another set of cuda-toolkit even if the conda environment is compatible with the requirements as indicated in https://github.com/google-research/timesfm/blob/master/pyproject.toml in more particular `Jax cuda-12 >= 0.4.26`. This arises because `timesfm` is specifically asking for jax[cuda12] but conda semantic is instead jax+jaxlib-cuda-12 which pip installer does not understand. The cuda is attached to jaxlib in conda. Removing cuda12 in jax semantic requirement allows the installation to proceed without messing up the existing ja+cuda-12 installations.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…semantic naming
Fixes #244
Installation of timefs results to installing another set of cuda-toolkit even if the conda environment is compatible with the requirements as indicated in https://github.com/google-research/timesfm/blob/master/pyproject.toml in more particular
Jax cuda-12 >= 0.4.26.This arises because
timesfmis specifically asking for jax[cuda12] but conda semantic is instead jax+jaxlib-cuda-12 which pip installer does not understand. The cuda is attached to jaxlib in conda.Removing cuda12 in jax semantic requirement allows the installation to proceed without messing up the existing ja+cuda-12 installations.