Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop telnet connection when client closes #447

Merged
merged 2 commits into from
Mar 3, 2021
Merged

Drop telnet connection when client closes #447

merged 2 commits into from
Mar 3, 2021

Conversation

NeilFraser
Copy link
Contributor

No description provided.

@NeilFraser NeilFraser requested a review from cpcallen February 5, 2021 19:45
@NeilFraser
Copy link
Contributor Author

Resolves #446

cpcallen
cpcallen approved these changes Feb 8, 2021
View reviewed changes
static/connect/connect.js Outdated
clearTimeout(CCC.nextPingPid);
var sendingJson = {
'q': CCC.queueId_,
'logout': 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not 'logout': true,?

@cpcallen
Copy link
Collaborator

Are you intending to rebase/merge this?

@NeilFraser NeilFraser merged commit a8c6b97 into master Mar 3, 2021
@NeilFraser NeilFraser deleted the fraser/disconnect branch March 3, 2021 18:46
cpcallen added a commit that referenced this pull request Mar 17, 2021
@cpcallen
Merge branch master into prod to get PRs #447, #453, #443, #454, #455 …
8c420f4 
…and #458
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcallen cpcallen cpcallen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NeilFraser @cpcallen