Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hostenv file storage #489
Hostenv file storage #489
Changes from 7 commits
db26f61
1cf7373
f2cb2f7
c0299c3
4e47968
660b6b7
2708074
0158cc8
cc1fb25
aea4c56
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have generally used
0xFF
. Is theu8
annotation is required?Other instances of this exist below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, for consistency with the rest of the library let's use
0xff
if Rust is able to infer the type.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this
std
condition correctly interact with the rest of the code? We usestd
for tests and fuzzing only so far. Therefore, I was wondering if you can just compile the OpenSK library withstd
later for non-testing purposes?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes,
std
means that we compile with the standard library (and thus an OS). We usestd
for tests and fuzzing because that's the only reason we need to compile on an OS. And this example is another reason now.Note that once CTAP is a library we will compile it with
std
for non-testing purposes too. This library is just one step ahead because it's already a library and doesn't depend on Tock.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, another use of
std
that is actually necessary outside of tests.