Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xRaddextexp - replaced yaml files with header table #7410

Merged
merged 5 commits into from
Dec 2, 2024
Merged

xRaddextexp - replaced yaml files with header table #7410

merged 5 commits into from
Dec 2, 2024

Conversation

nitheshsrikanth-mcw
Copy link
Contributor

No description provided.

@nitheshsrikanth-mcw nitheshsrikanth-mcw force-pushed the xnn_raddextexp branch 2 times, most recently from de662aa to e853c77 Compare November 4, 2024 13:37
dsharlet
dsharlet reviewed Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@dsharlet dsharlet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as #7408

@nitheshsrikanth-mcw nitheshsrikanth-mcw force-pushed the xnn_raddextexp branch 7 times, most recently from 2dfbc74 to 1e33a73 Compare November 6, 2024 12:34
dsharletg
dsharletg reviewed Nov 6, 2024
View reviewed changes
tools/generate-raddextexp-test.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this file

@dsharlet
Copy link
Collaborator

Update kernel declarations?

copybara-service bot pushed a commit that referenced this pull request Nov 12, 2024
@nitheshsrikanth-mcw @xnnpack-bot
Copybara import of the project:
8d121bf 
--
e853c77 by nithesh <[email protected]>:

Raddextexp - replaced yaml files with header table
Replaced yaml files with header table for Raddextexp op

--
1e33a73 by nithesh <[email protected]>:

Addressed review comments

--
d03ce4f by nithesh <[email protected]>:

Addressed review comments

FUTURE_COPYBARA_INTEGRATE_REVIEW=#7410 from nitheshsrikanth-mcw:xnn_raddextexp 8af7373
PiperOrigin-RevId: 695826022
@copybara-service copybara-service bot mentioned this pull request Nov 12, 2024
Closed
copybara-service bot pushed a commit that referenced this pull request Nov 12, 2024
@nitheshsrikanth-mcw @xnnpack-bot
Copybara import of the project:
a4172bf 
--
e853c77 by nithesh <[email protected]>:

Raddextexp - replaced yaml files with header table
Replaced yaml files with header table for Raddextexp op

--
1e33a73 by nithesh <[email protected]>:

Addressed review comments

--
d03ce4f by nithesh <[email protected]>:

Addressed review comments

FUTURE_COPYBARA_INTEGRATE_REVIEW=#7410 from nitheshsrikanth-mcw:xnn_raddextexp 8af7373
PiperOrigin-RevId: 695826022
copybara-service bot pushed a commit that referenced this pull request Nov 12, 2024
@nitheshsrikanth-mcw @xnnpack-bot
Copybara import of the project:
eec4c9f 
--
e853c77 by nithesh <[email protected]>:

Raddextexp - replaced yaml files with header table
Replaced yaml files with header table for Raddextexp op

--
1e33a73 by nithesh <[email protected]>:

Addressed review comments

--
d03ce4f by nithesh <[email protected]>:

Addressed review comments

FUTURE_COPYBARA_INTEGRATE_REVIEW=#7410 from nitheshsrikanth-mcw:xnn_raddextexp 8af7373
PiperOrigin-RevId: 695826022
dsharletg
dsharletg reviewed Nov 21, 2024
View reviewed changes
test/f32-raddextexp.cc
#define XNN_TEST_RADDEXTEXP_ELEMENT_DIV(ukernel, arch_flags, element_tile, ...) \
TEST(ukernel, element_gt) \
{ \
for (size_t element_size = element_tile * 2; element_size < element_tile * 10; element_size += element_tile) { \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TEST_REQUIRES_ARCH_FLAGS(arch_flags)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out the missing TEST_REQUIRES_ARCH_FLAGS(arch_flags). The issue with the illegal instruction for AVX-512 has now been resolved and now the tests are passing.

copybara-service bot pushed a commit that referenced this pull request Nov 28, 2024
@nitheshsrikanth-mcw @xnnpack-bot
Copybara import of the project:
b2661a2 
--
b5f46f0 by nithesh <[email protected]>:

Raddextexp - replaced yaml files with header table
Replaced yaml files with header table for Raddextexp op

--
ef023df by nithesh <[email protected]>:

Addressed review comments

--
246eafd by nithesh <[email protected]>:

Addressed review comments

--
b7c0f50 by nithesh <[email protected]>:

Addressed review comments and updated kernel declarations

--
183f7da by nithesh <[email protected]>:

Adderessed "illegal instructions" for AVX512F tests

FUTURE_COPYBARA_INTEGRATE_REVIEW=#7410 from nitheshsrikanth-mcw:xnn_raddextexp 183f7da
PiperOrigin-RevId: 700838467
@copybara-service copybara-service bot mentioned this pull request Nov 28, 2024
Merged
copybara-service bot pushed a commit that referenced this pull request Nov 28, 2024
@nitheshsrikanth-mcw @xnnpack-bot
Copybara import of the project:
3af7bd1 
--
b5f46f0 by nithesh <[email protected]>:

Raddextexp - replaced yaml files with header table
Replaced yaml files with header table for Raddextexp op

--
ef023df by nithesh <[email protected]>:

Addressed review comments

--
246eafd by nithesh <[email protected]>:

Addressed review comments

--
b7c0f50 by nithesh <[email protected]>:

Addressed review comments and updated kernel declarations

--
183f7da by nithesh <[email protected]>:

Adderessed "illegal instructions" for AVX512F tests

FUTURE_COPYBARA_INTEGRATE_REVIEW=#7410 from nitheshsrikanth-mcw:xnn_raddextexp 183f7da
PiperOrigin-RevId: 700838467
copybara-service bot pushed a commit that referenced this pull request Nov 28, 2024
@nitheshsrikanth-mcw @xnnpack-bot
Copybara import of the project:
6f4c50a 
--
b5f46f0 by nithesh <[email protected]>:

Raddextexp - replaced yaml files with header table
Replaced yaml files with header table for Raddextexp op

--
ef023df by nithesh <[email protected]>:

Addressed review comments

--
246eafd by nithesh <[email protected]>:

Addressed review comments

--
b7c0f50 by nithesh <[email protected]>:

Addressed review comments and updated kernel declarations

--
183f7da by nithesh <[email protected]>:

Adderessed "illegal instructions" for AVX512F tests

FUTURE_COPYBARA_INTEGRATE_REVIEW=#7410 from nitheshsrikanth-mcw:xnn_raddextexp 183f7da
PiperOrigin-RevId: 700838467
copybara-service bot pushed a commit that referenced this pull request Nov 29, 2024
@nitheshsrikanth-mcw @xnnpack-bot
Copybara import of the project:
3374469 
--
b5f46f0 by nithesh <[email protected]>:

Raddextexp - replaced yaml files with header table
Replaced yaml files with header table for Raddextexp op

--
ef023df by nithesh <[email protected]>:

Addressed review comments

--
246eafd by nithesh <[email protected]>:

Addressed review comments

--
b7c0f50 by nithesh <[email protected]>:

Addressed review comments and updated kernel declarations

--
118532a by nithesh <[email protected]>:

Adderessed "illegal instructions" for AVX512F tests

FUTURE_COPYBARA_INTEGRATE_REVIEW=#7410 from nitheshsrikanth-mcw:xnn_raddextexp 118532a
PiperOrigin-RevId: 700838467
copybara-service bot pushed a commit that referenced this pull request Nov 29, 2024
@nitheshsrikanth-mcw @xnnpack-bot
Copybara import of the project:
7c3ad27 
--
b5f46f0 by nithesh <[email protected]>:

Raddextexp - replaced yaml files with header table
Replaced yaml files with header table for Raddextexp op

--
ef023df by nithesh <[email protected]>:

Addressed review comments

--
246eafd by nithesh <[email protected]>:

Addressed review comments

--
b7c0f50 by nithesh <[email protected]>:

Addressed review comments and updated kernel declarations

--
118532a by nithesh <[email protected]>:

Adderessed "illegal instructions" for AVX512F tests

FUTURE_COPYBARA_INTEGRATE_REVIEW=#7410 from nitheshsrikanth-mcw:xnn_raddextexp 118532a
PiperOrigin-RevId: 700838467
copybara-service bot pushed a commit that referenced this pull request Nov 29, 2024
@nitheshsrikanth-mcw @xnnpack-bot
Copybara import of the project:
e0118da 
--
b5f46f0 by nithesh <[email protected]>:

Raddextexp - replaced yaml files with header table
Replaced yaml files with header table for Raddextexp op

--
ef023df by nithesh <[email protected]>:

Addressed review comments

--
246eafd by nithesh <[email protected]>:

Addressed review comments

--
b7c0f50 by nithesh <[email protected]>:

Addressed review comments and updated kernel declarations

--
118532a by nithesh <[email protected]>:

Adderessed "illegal instructions" for AVX512F tests

FUTURE_COPYBARA_INTEGRATE_REVIEW=#7410 from nitheshsrikanth-mcw:xnn_raddextexp 118532a
PiperOrigin-RevId: 700838467
copybara-service bot pushed a commit that referenced this pull request Dec 2, 2024
@nitheshsrikanth-mcw @xnnpack-bot
Copybara import of the project:
564ba0c 
--
b5f46f0 by nithesh <[email protected]>:

Raddextexp - replaced yaml files with header table
Replaced yaml files with header table for Raddextexp op

--
ef023df by nithesh <[email protected]>:

Addressed review comments

--
246eafd by nithesh <[email protected]>:

Addressed review comments

--
b7c0f50 by nithesh <[email protected]>:

Addressed review comments and updated kernel declarations

--
118532a by nithesh <[email protected]>:

Adderessed "illegal instructions" for AVX512F tests

FUTURE_COPYBARA_INTEGRATE_REVIEW=#7410 from nitheshsrikanth-mcw:xnn_raddextexp 118532a
PiperOrigin-RevId: 700838467
copybara-service bot pushed a commit that referenced this pull request Dec 2, 2024
@nitheshsrikanth-mcw @xnnpack-bot
Copybara import of the project:
d3dc03e 
--
b5f46f0 by nithesh <[email protected]>:

Raddextexp - replaced yaml files with header table
Replaced yaml files with header table for Raddextexp op

--
ef023df by nithesh <[email protected]>:

Addressed review comments

--
246eafd by nithesh <[email protected]>:

Addressed review comments

--
b7c0f50 by nithesh <[email protected]>:

Addressed review comments and updated kernel declarations

--
118532a by nithesh <[email protected]>:

Adderessed "illegal instructions" for AVX512F tests

FUTURE_COPYBARA_INTEGRATE_REVIEW=#7410 from nitheshsrikanth-mcw:xnn_raddextexp 118532a
PiperOrigin-RevId: 700838467
copybara-service bot pushed a commit that referenced this pull request Dec 2, 2024
@nitheshsrikanth-mcw @xnnpack-bot
Copybara import of the project:
0aa52dd 
--
b5f46f0 by nithesh <[email protected]>:

Raddextexp - replaced yaml files with header table
Replaced yaml files with header table for Raddextexp op

--
ef023df by nithesh <[email protected]>:

Addressed review comments

--
246eafd by nithesh <[email protected]>:

Addressed review comments

--
b7c0f50 by nithesh <[email protected]>:

Addressed review comments and updated kernel declarations

--
118532a by nithesh <[email protected]>:

Adderessed "illegal instructions" for AVX512F tests

FUTURE_COPYBARA_INTEGRATE_REVIEW=#7410 from nitheshsrikanth-mcw:xnn_raddextexp 118532a
PiperOrigin-RevId: 700838467
@copybara-service copybara-service bot merged commit ecf886d into google:master Dec 2, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsharletg dsharletg dsharletg left review comments

@dsharlet dsharlet dsharlet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nitheshsrikanth-mcw @dsharlet @dsharletg