Add types to build MAIR values. #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review of the terminology and naming would be particularly appreciated. |
qwandor
force-pushed
the
mair
branch
2 times, most recently
from
1544e99 to
0d63407
Compare
These let a constant MAIR value be built with a builder pattern and named constants, which should be more readable and safer than using bitwise operations directly. Display implementations are also included to format MAIR values in a human-readable form.
ardbiesheuvel
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These let a constant MAIR value be built with a builder pattern and named constants, which should be more readable and safer than using bitwise operations directly. Display implementations are also included to format MAIR values in a human-readable form.