Skip to content

Commit

Permalink
Remove redundant AND from ValidateClear
Browse files Browse the repository at this point in the history
Component types of disabled draw
buffers are already set to zero.

Bug: angleproject:8618
Change-Id: I193dc6249158c6314076fedc7b4f43261d81f074
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5419708
Reviewed-by: Shahbaz Youssefi <[email protected]>
Commit-Queue: Shahbaz Youssefi <[email protected]>
  • Loading branch information
lexaknyazev authored and Angle LUCI CQ committed Apr 3, 2024
1 parent ab6dd5b commit ceb3c0e
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/libANGLE/validationES2.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2615,9 +2615,7 @@ bool ValidateClear(const Context *context, angle::EntryPoint entryPoint, GLbitfi

if (extensions.webglCompatibilityANGLE && (mask & GL_COLOR_BUFFER_BIT) != 0)
{
const gl::DrawBufferMask intOrUnsignedIntMask =
GetIntOrUnsignedIntDrawBufferMask(fbo->getDrawBufferTypeMask());
if ((intOrUnsignedIntMask & fbo->getDrawBufferMask()).any())
if (GetIntOrUnsignedIntDrawBufferMask(fbo->getDrawBufferTypeMask()).any())
{
ANGLE_VALIDATION_ERROR(GL_INVALID_OPERATION, kNoDefinedClearConversion);
return false;
Expand Down

0 comments on commit ceb3c0e

Please sign in to comment.