Use vulkan descriptor arrays instead of flattening them #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, looks like the features aren't supported for our github CI. Maybe more of an argument for option #2? |
It might be a somewhat painful transition, but we should just assume those are supported. The argument for this is that it better aligns with D3D12 - in which these features are implicit. For the devices we'll care about those options will be present. |
|
Tested this against my local branch and it's working as expected for Vulkan. |
|
the CI is now good after upgrading to the new mesa vulkan drivers. I will finish testing this on a few devices/projects and then set to ready to review |
apazylbe
force-pushed
the
remove_flatten
branch
3 times, most recently
from
9f48da8 to
e82d63a
Compare
Keenuts
approved these changes
Nov 13, 2023
apazylbe
force-pushed
the
remove_flatten
branch
2 times, most recently
from
6c95b2b to
b9e24b9
Compare
In order to fully support resource arrays, also require and enable shader*ArrayDynamicIndexing device features. This allows one to use push constants to select texture within an array of textures like in 24_push_constants Does not add support for using push descriptors with arrays
apazylbe
force-pushed
the
remove_flatten
branch
from
b9e24b9 to
dfaa5f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to fully support resource arrays, also require and enable shader*ArrayDynamicIndexing device features.
This allows one to use push constants to select texture within an array of textures like in 24_push_constants
Does not add support for using push descriptors with arrays.
Dynamic indexing features are not required for just using shader resource arrays with constant indices.
Currently, from what I can tell, only 24_push_constants requires enabling shaderSampledImageArrayDynamicIndexing and there are some small number of gpus that don't support those features (software lavapipe).
We could handle this in a few different ways: