Update the asset file path for Android Benchmark app setup #333
Conversation
| @@ -1,5 +1,6 @@ | |||
| ArrayList projectAssets = [ | |||
| "benchmarks/shaders/spv", | |||
| "benchmarks/textures", | |||
There was a problem hiding this comment.
there are some textures under the Wood folder, are they used by benchmarks? if so, should we add the subfolder? if not, shall we remove those textures? https://github.com/google/bigwheels/tree/main/assets/benchmarks/textures/Wood
There was a problem hiding this comment.
I think these are used by the benchmark texture_transfer_cpu_to_gpu
There was a problem hiding this comment.
good to know, thanks
There was a problem hiding this comment.
I believe when you add a folder. all files inside it and its subfolders are also added, so we shouldn't need to add the Wood subfolder.
|
I tested this last update on the Benchmark app and it is working as expected now. |
LGTM |
|
Closing this PR since I created it over my local main branch and had several issues to rebase it. |
No description provided.