Knob: type deduction. #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm creating this since I failed copy-pasting knob type twice today. |
wangra-google
approved these changes
Nov 14, 2023
|
I'm going to wait for #343 to be reviewed and submitted, for the sake of not dealing with a bunch of local merge conflict. |
|
Note: this is 2 PRs: one is doing type deduction, the other changing the implementation of the color sliders in the sample. |
Knob types are defined in header already, let compiler deduce the type from knob variable when initializing them.
hysw
force-pushed
the
tianc-knob-init
branch
from
5c0521a to
b58d65f
Compare
Fair point, removed the second commit, I'll make a different PR. |
angela28chen
approved these changes
Nov 14, 2023
Keenuts
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Knob types are defined in header already,
let compiler deduce the type from knob variable
when initializing them.